fix: add on_permission_request handler for SDK >= 0.1.28#10
Merged
mowree merged 3 commits intomicrosoft:mainfrom Feb 28, 2026
Merged
fix: add on_permission_request handler for SDK >= 0.1.28#10mowree merged 3 commits intomicrosoft:mainfrom
mowree merged 3 commits intomicrosoft:mainfrom
Conversation
SDK v0.1.28 requires on_permission_request when creating sessions. Uses try/except for backward compatibility with older SDK versions. Refs: github/copilot-sdk#509, #554 Co-authored-by: GitHub Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
Adds a compatibility shim in the Copilot client wrapper so sessions created with Copilot SDK >= 0.1.28 provide the newly-required on_permission_request handler, while remaining compatible with older SDK versions.
Changes:
- Set
session_config["on_permission_request"]whencopilot.types.PermissionHandler(and its expected helper) is available. - Guard the new behavior with
try/except (ImportError, AttributeError)for backward compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add disable_sdk_bundled_binary fixture for mount tests (SDK now bundles binary) - Fix streaming timeout test: CopilotTimeoutError -> LLMTimeoutError - Add xfail for Gemini 25_describe scenario (LLM behavioral variance) - Refactor ARM64 skip to class-level decorator (DRY) - Rewrite model snapshot test: full 18-model list, fail on diff instead of skip Co-authored-by: GitHub Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK v0.1.28 requires on_permission_request when creating sessions. Uses try/except for backward compatibility with older SDK versions.
Refs: github/copilot-sdk#509, #554